-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace NormalizeJsonString with local helper func #32142
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hey @nam054 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
c322122
to
e4fd0cf
Compare
e4fd0cf
to
83aa83e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just left a few comments. Also, can we add an acceptance test to this resource?
f43c74e
to
f00857c
Compare
f00857c
to
58015df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one fix otherwise LGTM 🚀
$ go test -v ./internal/service/events/... -run='TestRuleEvent' -count=1
--- PASS: TestRuleEventPatternJSONDecoder (0.00s)
--- PASS: TestRuleEventPatternJSONDecoder/lessThanGreaterThan (0.00s)
--- PASS: TestRuleEventPatternJSONDecoder/ampersand (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 3.217s
$ make testacc TESTARGS='-run=TestAccEventsRule_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run=TestAccEventsRule_ -timeout 180m
--- PASS: TestAccEventsRule_patternJsonEncoder (27.68s)
--- PASS: TestAccEventsRule_eventBusARN (31.00s)
--- PASS: TestAccEventsRule_scheduleAndPattern (32.40s)
--- PASS: TestAccEventsRule_namePrefix (32.45s)
--- PASS: TestAccEventsRule_Name_generated (32.88s)
--- PASS: TestAccEventsRule_pattern (44.53s)
--- PASS: TestAccEventsRule_role (45.40s)
--- PASS: TestAccEventsRule_description (45.55s)
--- PASS: TestAccEventsRule_eventBusName (58.43s)
--- PASS: TestAccEventsRule_tags (58.46s)
--- PASS: TestAccEventsRule_isEnabled (58.75s)
--- PASS: TestAccEventsRule_basic (60.17s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 63.521s
2896d78
to
5a6768d
Compare
5a6768d
to
4acc68c
Compare
This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The unicode conversion of
<
>
&
currently is causing issues for EventBridge rules. Instead ofNormalizeJsonString
we'll use a local helper function that will escape those characters.Relations
References
Output from Acceptance Testing